Create the API Definitions as Structs in the API Component #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
force-pushed
the
api-updates
branch
2 times, most recently
from
3a68e99
to
7613063
Compare
mjlshen
reviewed
Mar 19, 2024
mbarnes
force-pushed
the
api-updates
branch
2 times, most recently
from
144adbb
to
355c377
Compare
mbarnes
force-pushed
the
api-updates
branch
6 times, most recently
from
0a360d5
to
2b1b2b9
Compare
mbarnes
requested review from
petrkotas,
s-amann,
bennerv,
UlrichSchlueter and
jharrington22
as code owners
added 5 commits
April 3, 2024 12:34
This uses OpenShift API types for the internal representation of a cluster's ExternalAuths. The types are not a 100% match to our representation (data is stored in what are supposed to be config map or secret name references) but it's close enough. Adds a dependency on github.com/openshift/api.
Remove clusterFromRequest() and "cache" as a valid API version.
s-amann
previously approved these changes
Apr 4, 2024
The API version middleware will catch an invalid API version and complete the request before the final handler function executes, so handler functions can safely get the versioned interface from the request context.
s-amann
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes JIRA story ARO-5411 - Create the API Definitions as Structs in the API Component
This will remain in Draft until #7 is finalized.